Stop testing workspace tests with any kind, and use specific kinds instead#1572
Open
BenjaminSchubert wants to merge 1 commit intomasterfrom
Open
Stop testing workspace tests with any kind, and use specific kinds instead#1572BenjaminSchubert wants to merge 1 commit intomasterfrom
BenjaminSchubert wants to merge 1 commit intomasterfrom
Conversation
BenjaminSchubert
force-pushed
the
bschubert/remove-multiple-kinds-source-tests-in-workspace
branch
from
da9502a to
5c6ce74
Compare
BenjaminSchubert
force-pushed
the
bschubert/remove-multiple-kinds-source-tests-in-workspace
branch
from
5c6ce74 to
19bc295
Compare
…cific kinds instead If we need multiple kinds for those tests, we should rewrite those as parametrized source tests
BenjaminSchubert
force-pushed
the
bschubert/remove-multiple-kinds-source-tests-in-workspace
branch
from
19bc295 to
9f25e1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gtristan @juergbi Do we want to move some of those tests as part of the source tests instead? If so, I'm happy to move them from here too.
Depends on #1566, so no need to review that part here.